【Hackathon 7th No.28】为 paddle.clip 进行功能增强#69193
Closed
a162837 wants to merge 3 commits intoPaddlePaddle:developfrom
Closed
【Hackathon 7th No.28】为 paddle.clip 进行功能增强#69193a162837 wants to merge 3 commits intoPaddlePaddle:developfrom
a162837 wants to merge 3 commits intoPaddlePaddle:developfrom
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Author
|
已经全都好了，麻烦review一下 @luotao1 @zhwesky2010 |
Contributor
|
这个还是不能在python层写，需改造已有的kernel |
Author
改造已有kernel的话，是除了cpu，gpu的其他计算芯片也都实现吗？然后也需要实现对应的二阶推导对吗 |
Author
|
改造已有的，我也想过，就是同样是expand结合where实现，传入scale的时候使用full_like转为Tensor。这样是可以的吧 |
Author
|
我参考paddle.where的做法实现吧，是可以的吧？ @zhwesky2010 |
Author
|
他一直不变的？ |
Author
|
我觉得这个难度是不是标错了？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Inference
PR Types
Others
Description
【Hackathon 7th No.28】为 paddle.clip 进行功能增强
PaddlePaddle/docs#6924