Use named logger instead of modifying root logger#17684
Merged
luotao1 merged 2 commits intoPaddlePaddle:mainfrom Feb 28, 2026
Merged
Use named logger instead of modifying root logger#17684luotao1 merged 2 commits intoPaddlePaddle:mainfrom
luotao1 merged 2 commits intoPaddlePaddle:mainfrom
Conversation
Replace logging.basicConfig() and logging.info() calls with a named
logger (logging.getLogger("ppocr")) in generate_multi_language_configs.py
to avoid mutating the Python root logger and overriding user logging
configuration.
Fixes PaddlePaddle#17344
|
Thanks for your contribution! |
|
|
Contributor
Author
|
recheck |
Bobholamovic
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logging.basicConfig(level=logging.INFO)with a named logger (logging.getLogger("ppocr")) inconfigs/rec/multi_language/generate_multi_language_configs.pylogging.info(...)calls withlogger.info(...)to use the named logger instead of the root loggerFixes #17344
Test plan
generate_multi_language_configs.pystill logs correctly when run directlylogging.basicConfig(level=logging.WARNING)) is preserved after PaddleOCR initialization