fix(deps)!: remove @backstage/backend-common #130
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR remove
@backstage/backend-commonsas a dependency.With this change, users of the legacy system are now required to pass in a config and auth to
createRouterand they are required to pass options tocreatePagerDutyServiceAction(theconfigfield was already required).This is technically a breaking change and I'm honestly not quite sure how to handle it because it depends on how the PagerDuty team wants to handle support for the legacy backend system. I opted to open this PR early to get an idea of what the code change would look like and what kind of an effect it would have.
Issue number: (e.g. #129)
Affected plugin
Type of change
Checklist
If this is a breaking change 👇
Acknowledgement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.