Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 10-OAuth-2-PKCE.md #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update 10-OAuth-2-PKCE.md #63

wants to merge 1 commit into from

Conversation

abs
Copy link

@abs abs commented Mar 11, 2023

Base64 URL Encoded (without padding) string containing the SHA-256 digested form of the clients one-time random 128 byte verifier (also in Base64URLEncoded form without padding).

"clients" is incorrect, needs to be "client's"

"128 byte verifier" is incorrect - it's 128-byte after the verifier is base64-encoded. Actual verifier can be somewhere between 90 and 110 bytes; example code uses 93, so let's go with that.

Description

  • Add a simple description of the changes

Jira Ticket

  • Ref a Jira Ticket if it exists.

Before Merging!

  • Check staging environment to ensure changes look as intended.
  • Ensure there is a review from DevFoundations and from Community.

> Base64 URL Encoded (without padding) string containing the SHA-256 digested form of the clients one-time random 128 byte verifier (also in Base64URLEncoded form without padding). 

"clients" is incorrect, needs to be "client's"

"128 byte verifier" is incorrect - it's 128-byte *after* the verifier is base64-encoded. Actual verifier can be somewhere between 90 and 110 bytes; example code uses 93, so let's go with that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant