Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/node-20-support #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feature/node-20-support #4

wants to merge 2 commits into from

Conversation

royanon
Copy link

@royanon royanon commented Nov 29, 2023

  • feature node 20 support

@royanon royanon mentioned this pull request Nov 29, 2023
Closed
JakobLierman
JakobLierman approved these changes Nov 29, 2023
View reviewed changes
Copy link

@JakobLierman JakobLierman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why still support deprecated Node versions that are not in maintenance anymore? Bumping the minimum version would indeed require a major version bump, but that's all AFAIK.
People that are still using old Node versions can continue to use an older version of this package.
Besides that, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobLierman JakobLierman JakobLierman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royanon @JakobLierman