-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Unify #TODO markers in examples tfvars #33
Conversation
…obal Protect e.g.: 134.238.135.14, 134.238.135.140
/help ChatOPS built in help:Currently supported commands include:
The 1st command does not take arguments, the remaining take two:
Examples: # run idempotence tests on listed modules with Terraform versions: 1.2 (latest patch available), 1.4 (latest patch available), 1.5.4.
/idempotence paths="examples/common_vmseries examples/panorama_standalone" tf_version="1.2 1.4 1.5.4" # run validation tests with the latest available Terraform version on listed modules.
/validate paths="modules/vmseries modules/vnet examples/dedicated_vmseries" |
/plan paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries"
|
…/pkg/testskeleton for Terratest in test infrastructure
/plan paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great work! Let's just confirm with Migara if we're OK with leaving "0.0.0.0/0" as the default behaviour.
P.S. Good catch on the random password generation. :)
/plan paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries"
|
Description
PR delivers changes:
common_vmseries_and_autoscale
,dedicated_vmseries
,dedicated_vmseries_and_autoscale
)github.com/PaloAltoNetworks/terraform-modules-swfw-tests-skeleton/pkg/testskeleton
for Terratest in test infrastructure moduleMotivation and Context
#32
How Has This Been Tested?
Code is being tested via ChatOps
Types of changes
Checklist