Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unify #TODO markers in examples tfvars #33

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Mar 29, 2024

Description

PR delivers changes:

  • Unify #TODO markers in examples tfvars
  • Remove all public IPs from Global Protect e.g.: 134.238.135.14, 134.238.135.140
  • Fix issues with password for test infrastructure (examples: common_vmseries_and_autoscale, dedicated_vmseries, dedicated_vmseries_and_autoscale)
  • Use github.com/PaloAltoNetworks/terraform-modules-swfw-tests-skeleton/pkg/testskeleton for Terratest in test infrastructure module

Motivation and Context

#32

How Has This Been Tested?

Code is being tested via ChatOps

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech requested a review from a team as a code owner March 29, 2024 13:52
@sebastianczech sebastianczech changed the base branch from main to refactor-modules March 29, 2024 13:52
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Mar 29, 2024

/help

ChatOPS built in help:

Currently supported commands include:

  • /sca - run all SCA tests via pre-commit
  • /validate - run terraform validate
  • /plan - plan the infrastructure (only examples)
  • /apply - deploy the infrastructure and destroy afterwards (only examples)
  • /idempotence - test idempotence: deploy, plan and destroy afterwards (only examples).

The 1st command does not take arguments, the remaining take two:

  • paths - a space delimitied list of module paths
  • tf_version - (optional, defaults to the latest available) a space delimited list of Terraform versions to test the infrastrucure against.

Examples:

# run idempotence tests on listed modules with Terraform versions: 1.2 (latest patch available), 1.4 (latest patch available), 1.5.4.
/idempotence paths="examples/common_vmseries examples/panorama_standalone" tf_version="1.2 1.4 1.5.4"
# run validation tests with the latest available Terraform version on listed modules.
/validate paths="modules/vmseries modules/vnet examples/dedicated_vmseries"

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Mar 29, 2024

/plan paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries"

Testing job ID: 8481710057
Job result: FAILURE

…/pkg/testskeleton for Terratest in test infrastructure
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Mar 29, 2024

/plan paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries"

Testing job ID: 8481759038
Job result: SUCCESS

Copy link
Contributor

@acelebanski acelebanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work! Let's just confirm with Migara if we're OK with leaving "0.0.0.0/0" as the default behaviour.

P.S. Good catch on the random password generation. :)

@acelebanski acelebanski added the refactor Related to code refactoring label Apr 3, 2024
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Apr 5, 2024

/plan paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries"

Testing job ID: 8566228691
Job result: SUCCESS

@acelebanski acelebanski merged commit 655eba0 into refactor-modules Apr 5, 2024
@acelebanski acelebanski deleted the refactor-modules-32 branch April 5, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Related to code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants