Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Unify #TODO markers in examples tfvars #33

Merged
merged 5 commits into from
Apr 5, 2024
Merged

feat: Unify #TODO markers in examples tfvars #33

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87c0de7
Unify #TODO markers in examples tfvars, remove all public IPs from Gl…
sebastianczech Mar 29, 2024
b2d7f11
Fix issues with password for test infrastructure
sebastianczech Mar 29, 2024
c80a345
Use github.com/PaloAltoNetworks/terraform-modules-swfw-tests-skeleton…
sebastianczech Mar 29, 2024
6815e8f
Merge branch 'refactor-modules' into refactor-modules-32
sebastianczech Apr 5, 2024
4bb873c
Replace 0.0.0.0/0 by 1.1.1.1/32 in NSGs in example.tfvars
sebastianczech Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/appgw/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,4 +376,5 @@ Default value: `true`




<!-- END_TF_DOCS -->
1 change: 1 addition & 0 deletions examples/common_vmseries/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,4 +1326,5 @@ Default value: `map[]`

<sup>[back to list](#modules-optional-inputs)</sup>


<!-- END_TF_DOCS -->
6 changes: 3 additions & 3 deletions examples/common_vmseries/example.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ vnets = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["134.238.135.14", "134.238.135.140"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.0.0.0/28"
destination_port_ranges = ["22", "443"]
Expand Down Expand Up @@ -303,7 +303,7 @@ test_infrastructure = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["134.238.135.14", "134.238.135.140"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access test infrastructure
source_port_range = "*"
destination_address_prefix = "10.100.0.0/25"
destination_port_ranges = ["80", "443"]
Expand Down Expand Up @@ -369,7 +369,7 @@ test_infrastructure = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["134.238.135.14", "134.238.135.140"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access test infrastructure
source_port_range = "*"
destination_address_prefix = "10.100.1.0/25"
destination_port_ranges = ["80", "443"]
Expand Down
1 change: 1 addition & 0 deletions examples/common_vmseries_and_autoscale/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,4 +1218,5 @@ Default value: `map[]`

<sup>[back to list](#modules-optional-inputs)</sup>


<!-- END_TF_DOCS -->
8 changes: 4 additions & 4 deletions examples/common_vmseries_and_autoscale/example.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ vnets = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["0.0.0.0/0"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.0.0.0/28"
destination_port_ranges = ["22", "443"]
Expand Down Expand Up @@ -133,7 +133,7 @@ load_balancers = {
nsg_auto_rules_settings = {
nsg_vnet_key = "transit"
nsg_key = "public"
source_ips = ["0.0.0.0/0"] # Put your own public IP address here <-- TODO to be adjusted by the customer
source_ips = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access LB
}
frontend_ips = {
"app1" = {
Expand Down Expand Up @@ -313,7 +313,7 @@ test_infrastructure = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["134.238.135.14", "134.238.135.140"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.100.0.0/25"
destination_port_ranges = ["80", "443"]
Expand Down Expand Up @@ -379,7 +379,7 @@ test_infrastructure = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["134.238.135.14", "134.238.135.140"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access test infrastructure
source_port_range = "*"
destination_address_prefix = "10.100.1.0/25"
destination_port_ranges = ["80", "443"]
Expand Down
4 changes: 3 additions & 1 deletion examples/common_vmseries_and_autoscale/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ resource "random_password" "this" {
count = anytrue([
for _, v in var.scale_sets : v.authentication.password == null
if !v.authentication.disable_password_authentication
]) ? 1 : 0
]) ? (
anytrue([for _, v in var.test_infrastructure : v.authentication.password == null]) ? 2 : 1
) : 0

length = 16
min_lower = 16 - 4
Expand Down
1 change: 1 addition & 0 deletions examples/dedicated_vmseries/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,4 +1330,5 @@ Default value: `map[]`

<sup>[back to list](#modules-optional-inputs)</sup>


<!-- END_TF_DOCS -->
8 changes: 4 additions & 4 deletions examples/dedicated_vmseries/example.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ vnets = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["134.238.135.14", "134.238.135.140"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.0.0.0/28"
destination_port_ranges = ["22", "443"]
Expand Down Expand Up @@ -168,7 +168,7 @@ bootstrap_storages = {
storage_network_security = {
vnet_key = "transit"
allowed_subnet_keys = ["management"]
allowed_public_ips = ["134.238.135.14", "134.238.135.140"]
allowed_public_ips = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access storage account
}
}
}
Expand Down Expand Up @@ -334,7 +334,7 @@ test_infrastructure = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["134.238.135.14", "134.238.135.140"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access test infrastructure
source_port_range = "*"
destination_address_prefix = "10.100.0.0/25"
destination_port_ranges = ["80", "443"]
Expand Down Expand Up @@ -400,7 +400,7 @@ test_infrastructure = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["134.238.135.14", "134.238.135.140"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access test infrastructure
source_port_range = "*"
destination_address_prefix = "10.100.1.0/25"
destination_port_ranges = ["80", "443"]
Expand Down
6 changes: 3 additions & 3 deletions examples/dedicated_vmseries/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

# https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/password
resource "random_password" "this" {
count = anytrue([
for _, v in var.vmseries : v.authentication.password == null
]) ? 1 : 0
count = anytrue([for _, v in var.vmseries : v.authentication.password == null]) ? (
anytrue([for _, v in var.test_infrastructure : v.authentication.password == null]) ? 2 : 1
) : 0

length = 16
min_lower = 16 - 4
Expand Down
1 change: 1 addition & 0 deletions examples/dedicated_vmseries_and_autoscale/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1212,4 +1212,5 @@ Default value: `map[]`

<sup>[back to list](#modules-optional-inputs)</sup>


<!-- END_TF_DOCS -->
8 changes: 4 additions & 4 deletions examples/dedicated_vmseries_and_autoscale/example.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ vnets = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["0.0.0.0/0"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.0.0.0/28"
destination_port_ranges = ["22", "443"]
Expand Down Expand Up @@ -133,7 +133,7 @@ load_balancers = {
nsg_auto_rules_settings = {
nsg_vnet_key = "transit"
nsg_key = "public"
source_ips = ["0.0.0.0/0"] # Put your own public IP address here <-- TODO to be adjusted by the customer
source_ips = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access LB
}
frontend_ips = {
"app1" = {
Expand Down Expand Up @@ -263,7 +263,7 @@ test_infrastructure = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["134.238.135.14", "134.238.135.140"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access test infrastructure
source_port_range = "*"
destination_address_prefix = "10.100.0.0/25"
destination_port_ranges = ["80", "443"]
Expand Down Expand Up @@ -329,7 +329,7 @@ test_infrastructure = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["134.238.135.14", "134.238.135.140"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access test infrastructure
source_port_range = "*"
destination_address_prefix = "10.100.1.0/25"
destination_port_ranges = ["80", "443"]
Expand Down
4 changes: 3 additions & 1 deletion examples/dedicated_vmseries_and_autoscale/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ resource "random_password" "this" {
count = anytrue([
for _, v in var.scale_sets : v.authentication.password == null
if !v.authentication.disable_password_authentication
]) ? 1 : 0
]) ? (
anytrue([for _, v in var.test_infrastructure : v.authentication.password == null]) ? 2 : 1
) : 0

length = 16
min_lower = 16 - 4
Expand Down
1 change: 1 addition & 0 deletions examples/gwlb_with_vmseries/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,4 +977,5 @@ Default value: `map[]`

<sup>[back to list](#modules-optional-inputs)</sup>


<!-- END_TF_DOCS -->
4 changes: 2 additions & 2 deletions examples/gwlb_with_vmseries/example.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ vnets = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["0.0.0.0/0"] # TODO: whitelist public IP addresses that will be used to manage the appliances
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.0.0.0/28"
destination_port_ranges = ["22", "443"]
Expand Down Expand Up @@ -126,7 +126,7 @@ bootstrap_storages = {
storage_network_security = {
vnet_key = "transit"
allowed_subnet_keys = ["management"]
allowed_public_ips = ["0.0.0.0/0"] # TODO: whitelist public IP addresses that will be used to manage the appliances
allowed_public_ips = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access storage account
}
}
}
Expand Down
1 change: 1 addition & 0 deletions examples/standalone_panorama/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,4 +476,5 @@ Default value: `map[]`

<sup>[back to list](#modules-optional-inputs)</sup>


<!-- END_TF_DOCS -->
2 changes: 1 addition & 1 deletion examples/standalone_panorama/example.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ vnets = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["0.0.0.0/0"] # TODO: whitelist public IP addresses that will be used to manage the appliances
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.1.0.0/24"
destination_port_ranges = ["22", "443"]
Expand Down
1 change: 1 addition & 0 deletions examples/standalone_vmseries/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,4 +1261,5 @@ Default value: `map[]`

<sup>[back to list](#modules-optional-inputs)</sup>


<!-- END_TF_DOCS -->
2 changes: 1 addition & 1 deletion examples/standalone_vmseries/example.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ vnets = {
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["1.2.3.4"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.0.0.0/28"
destination_port_ranges = ["22", "443"]
Expand Down
1 change: 1 addition & 0 deletions examples/virtual_network_gateway/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,4 +314,5 @@ Default value: `map[]`

<sup>[back to list](#modules-optional-inputs)</sup>


<!-- END_TF_DOCS -->
1 change: 1 addition & 0 deletions modules/appgw/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1485,4 +1485,5 @@ Default value: `map[]`
<sup>[back to list](#modules-optional-inputs)</sup>



<!-- END_TF_DOCS -->
2 changes: 1 addition & 1 deletion modules/bootstrap/.header.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ module "bootstrap" {
}
storage_network_security = {
min_tls_version = "TLS1_1"
allowed_public_ips = ["1.2.3.4"]
allowed_public_ips = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access storage account
}
file_shares = {
"vm01" = {
Expand Down
2 changes: 1 addition & 1 deletion modules/bootstrap/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ module "bootstrap" {
}
storage_network_security = {
min_tls_version = "TLS1_1"
allowed_public_ips = ["1.2.3.4"]
allowed_public_ips = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to access storage account
}
file_shares = {
"vm01" = {
Expand Down
1 change: 1 addition & 0 deletions modules/loadbalancer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,4 +460,5 @@ Default value: `&{}`

<sup>[back to list](#modules-optional-inputs)</sup>


<!-- END_TF_DOCS -->
1 change: 1 addition & 0 deletions modules/virtual_network_gateway/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,4 +814,5 @@ Default value: `map[]`

<sup>[back to list](#modules-optional-inputs)</sup>


<!-- END_TF_DOCS -->
4 changes: 2 additions & 2 deletions modules/vnet/.header.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ This module is designed to work in several *modes* depending on which variables
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["1.2.3.4"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.0.0.0/28"
destination_port_ranges = ["22", "443"]
Expand Down Expand Up @@ -91,7 +91,7 @@ This module is designed to work in several *modes* depending on which variables
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["1.2.3.4"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.0.0.0/28"
destination_port_ranges = ["22", "443"]
Expand Down
4 changes: 2 additions & 2 deletions modules/vnet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ This module is designed to work in several *modes* depending on which variables
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["1.2.3.4"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.0.0.0/28"
destination_port_ranges = ["22", "443"]
Expand Down Expand Up @@ -91,7 +91,7 @@ This module is designed to work in several *modes* depending on which variables
direction = "Inbound"
access = "Allow"
protocol = "Tcp"
source_address_prefixes = ["1.2.3.4"]
source_address_prefixes = ["0.0.0.0/0"] # TODO: Whitelist public IP addresses that will be used to manage the appliances
source_port_range = "*"
destination_address_prefix = "10.0.0.0/28"
destination_port_ranges = ["22", "443"]
Expand Down