Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce subscription_id to examples and update deployment steps #100

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat: Introduce subscription_id to examples and update deployment steps #100

merged 3 commits into from
Oct 10, 2024

Conversation

acelebanski
Copy link
Contributor

@acelebanski acelebanski commented Oct 8, 2024 •
edited
Loading

Description

This PR:

  • introduces subscription_id variable into the examples
  • updates the examples READMEs, specifically adds a new deployment step which is providing the Subscription ID.

Motivation and Context

Since AzureRM provider version 4 it's required to provide Subscription ID to run terraform plan or terraform apply.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the documentation Improvements or additions to documentation label Oct 8, 2024
@acelebanski acelebanski requested a review from a team as a code owner October 8, 2024 18:33
@acelebanski acelebanski linked an issue Oct 8, 2024 that may be closed by this pull request
Update the example docs to reflect the use of subscription_id #95
Closed
@acelebanski acelebanski changed the title docs: Add information about subscription_id to READMEs feat: Add information about subscription_id to READMEs Oct 9, 2024
@acelebanski acelebanski added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Oct 9, 2024
@acelebanski acelebanski changed the title feat: Add information about subscription_id to READMEs feat: Introduce subscription_id to examples and update deployment steps Oct 9, 2024
@acelebanski acelebanski merged commit 74b5011 into main Oct 10, 2024
70 checks passed
@acelebanski acelebanski deleted the subscription-id-docs branch October 10, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migara migara migara approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the example docs to reflect the use of subscription_id
2 participants
@acelebanski @migara