-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Bump pre-commit and remediate checkov warnings #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pre-commit version bumped from 3.6.0 to 3.7.0
tlfint version bumped from 1.83.0 to v1.88.4
checkov version bumped from 2.4.22 to 3.2.50
The following checkov checks have been addressed:
Check:
CKV_AZURE_44
: "Ensure Storage Account is using the latest version of TLS encryption"Check:
CKV_AZURE_50
: "Ensure Virtual Machine Extensions are not Installed"Check:
CKV2_AZURE_41
: "Ensure storage account is configured with SAS expiration policy"Check:
CKV2_AZURE_38
: "Ensure soft-delete is enabled on Azure storage account"Check:
CKV2_AZURE_40
: "Ensure storage account is not configured with Shared Key authorization"Check:
CKV2_AZURE_47
: "Ensure storage account is configured without blob anonymous access"Check:
CKV2_AZURE_39
: "Ensure Azure VM is not configured with public IP and serial console access"Check:
CKV_GHA_7
: "The build output cannot be affected by user parameters other than the build entry point and the top-level source location. GitHub Actions workflow_dispatch inputs MUST be empty. “Check:
CKV2_GHA_1
: "Ensure top-level permissions are not set to write-all"Motivation and Context
So the refactor supports newest pre-commit version together with its dependencies.
How Has This Been Tested?
I deployed some of the relevant examples.
Types of changes
Checklist