Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restrict maximum AzureRM provider version for bootstrap module #36

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

acelebanski
Copy link
Contributor

Description

This PR adds a new AzureRM provider version constraint that limit maximum provider version to 3.95 in the bootstrap module (temporary solution).

Motivation and Context

Our examples utilising bootstrap module currently don't work with the newest AzureRM provider version (this is observed since version 3.96). On HashiCorp side, it seems that they addressed this issue but the fix hasn't been released yet.

Once the problem is fixed on the HashiCorp side, we will switch to the newest AzureRM provider version.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the bug Something isn't working label Apr 3, 2024
@acelebanski acelebanski requested a review from a team as a code owner April 3, 2024 11:13
Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@acelebanski acelebanski merged commit 2619842 into main Apr 3, 2024
42 checks passed
@acelebanski acelebanski deleted the provider_bootstrap_issue branch April 3, 2024 22:02
@michalbil
Copy link
Contributor

@acelebanski, fix has been released in v3.98.0.

@acelebanski
Copy link
Contributor Author

acelebanski commented Apr 15, 2024

@michalbil yeah I know, we discussed it on the last planning meeting. In refactor branch it's set as minimum version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants