Skip to content

Add icons for gPlanarity#3659

Open
sled45 wants to merge 2 commits intoPapirusDevelopmentTeam:masterfrom
sled45:sled45-gplanarity
Open

Add icons for gPlanarity#3659
sled45 wants to merge 2 commits intoPapirusDevelopmentTeam:masterfrom
sled45:sled45-gplanarity

Conversation

@sled45
Copy link

@sled45 sled45 commented Mar 5, 2024

These icons should work. The .desktop file for gPlanarity is hardcoded though, so I opened an issue in hardcode-fixer.

@SmartFinn
Copy link
Member

Thanks for the contribution.

The icons have some issues:

  1. The icons have poor pixel alignment. The edges of objects do not fit the pixel grid. See Pixel alignment.
  2. Outlines, shadows, and the color of the circle do not match Papirus style. See [email protected] files as an example.
    1. Outlines and shadows should be 1px for 32-64px icons, and 0.5 px for 22-24px icons.
    2. The shadows should be below the objects.
    3. The lighter color of the base circle should be #e4e4e4.

@sled45
Copy link
Author

sled45 commented Mar 5, 2024

I made changes based off the guidelines and your comments. Hopefully it looks better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants