Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for some Amiga emulation files #3885

Merged

Conversation

achadwick
Copy link
Contributor

This commit adds icons for a couple of established file formats with the .adf extension and different signatures. They're floppy images, not ISO, and not optical anything, so the old symlink wasn't really appropriate.

  • application/x-amiga-disk-format (fs-uae's ADF_NORMAL)
    Packaged in current Debian testing's shared-mime-info.

  • application/x-adf (fs-uae's ADF_EXT1)
    Packaged in current Debian testing's fs-uae.

There are a number of other disk formats out there that don't have MIME types that I can find. Some of them are generic disk dumps, others are very specific to the Amiga: https://en.wikipedia.org/wiki/Amiga_Disk_File

Not a lot we can do about the (prebuilt) WHDLoad format that's supported by some emulators. That's just a .lha archive without much regularity inside it, & no specific MIME type: https://en.wikipedia.org/wiki/WHDLoad

Related issue: #2505


application-x-amiga-disk-format@64x64 application-x-amiga-disk-format@48x48 application-x-amiga-disk-format@32x32 application-x-amiga-disk-format@24x24 application-x-amiga-disk-format@22x22 application-x-amiga-disk-format@16x16

Oh no, a gradient. I hope the aesthetics are OK here, and that "object on top of object" is valid Papirus style. If you really would prefer a flat logo, or a boing ball, I can do that. However that rainbow double tick on a purple background should frankly yell "Amiga 3.1 boot screen" to anyone who knows it, and it echoes the fs-uae icon plenty too. Perhaps more than the exiting Papirus icon does.

achadwick added a commit to achadwick/papirus-icon-theme that referenced this pull request Dec 29, 2024
@achadwick
Copy link
Contributor Author

Looking at the upstream fs-uae icon, that also uses a pair of vertical gradients rather than the Papirus icon's rather odd choice of orange and green stripes. Let me know if you want me to update the the fs-uae icons to match this, or if you prefer that over this gradient.

@achadwick achadwick mentioned this pull request Jan 5, 2025
30 tasks
@morganist
Copy link
Member

hello,
please reconsider the gradient. the redesign looks nice, but the graduent is a big no in Papirus. you can get examples of how we work around a gradient if you look at icons for Firefox, Thunderbird, MS Edge and MS 365, among others.

@achadwick
Copy link
Contributor Author

@morganist I'll do that, and see what I can do to get it looking nice.

(Video co-processor gradients of course were a major feature on the Amiga itself, 😆)

@achadwick achadwick marked this pull request as draft January 15, 2025 17:27
This commit adds icons for a couple of established file formats with
the .adf extension and different signatures. They're floppy images,
not ISO, and not optical anything, so the old symlink wasn't really
appropriate.

- application/x-amiga-disk-format (fs-uae's ADF_NORMAL)
  Packaged in current Debian testing's shared-mime-info.

- application/x-adf (fs-uae's ADF_EXT1)
  Packaged in current Debian testing's fs-uae.

There are a number of other disk formats out there that don't have MIME
types that I can find. Some of them are generic disk dumps, others are
very specific to the Amiga: https://en.wikipedia.org/wiki/Amiga_Disk_File

Not a lot we can do about the (prebuilt) WHDLoad format that's supported
by some emulators. That's just a .lha archive without much regularity
inside it, & no specific MIME type: https://en.wikipedia.org/wiki/WHDLoad
@achadwick achadwick force-pushed the amiga-adf-mimetypes branch from 72db7a6 to 8f7d4d0 Compare January 16, 2025 04:00
@achadwick achadwick marked this pull request as ready for review January 16, 2025 04:01
@achadwick
Copy link
Contributor Author

@morganist OK, I've worked around the gradient like you asked. Ready to go.

@morganist morganist merged commit 99a176d into PapirusDevelopmentTeam:master Jan 16, 2025
1 check passed
@morganist
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants