-
Notifications
You must be signed in to change notification settings - Fork 164
API changes: particleset.py and grid.py
#1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6c51d9 to
0e57537
Compare
0e57537 to
f174e36
Compare
lon, lon, depth
lonlat_minmax, meridional_halo, mesh, time_origin
zonal_halo, zonal_periodic, defer_load, cell_edge_sizes
xdim, ydim
218b9bb to
9828b72
Compare
particleset.py and grid.pyparticleset.py and grid.py
erikvansebille
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1695
Changes
test_deprecations.pystructure (parity with the spreadsheet)pytestconf addingslowandflakymarkersThis PR makes many of the names in
particleset.pyandgrid.py:All privatisations are done in a non-breaking way, raising a deprecation warning.
The method/attributes affected are: