Reverting back to float for time and dt inside pset.execute #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…marking-running-bugs
for more information, see https://pre-commit.ci
|
Turns out that |
|
Actually, I now see that the particle-as-float may improve performance by a factor 2 for very large particle numbers ( |
…particle_time_as_float
for more information, see https://pre-commit.ci
|
We're not pursuing this anymore; we're also getting good performance with numpy.datetime64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting to using
float64fortimeanddtinpset.execute(), because it might increase performance a lot (to be explored). See also Parcels-code/parcels-benchmarks#1mainfor v3 changes,v4-devfor v4 changes)