Performance boost: calling numpy data in particle.__setattr__ #2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this does not appear to result in a speed-up
|
Turns out the using an xarray dataset for particleset data is inherently slow (see Parcels-code/parcels-benchmarks#1 (comment)), so closing this PR. We'll instead implement #2094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple change improves the performance of the Kernel loop by a factor 6, as updating the particle values seems to be the bottle neck in performance for the Kernel loop now
mainfor v3 changes,v4-devfor v4 changes)