Adding in the Runge-Kutta 2 advection schemes #2315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvansebille
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
@VeckoTheGecko, do we really need to add new Kernels at three locations? (two locations here in __init__.py and also at the top of advection.py). Can there not be less duplication?
There was a problem hiding this comment.
We can make advection.py private (i.e., changing it to be _advection.py). Then we wouldn't need to define __all__ in advection.py. As it stands though, we need to have it in __all__ for advection.py and __init__.py
VeckoTheGecko
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
We can make advection.py private (i.e., changing it to be _advection.py). Then we wouldn't need to define __all__ in advection.py. As it stands though, we need to have it in __all__ for advection.py and __init__.py
Instead directly using Kernel functions in test_advection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented the RK2 and RK2_3D schemes for v4. I've also added the two schemes to (some of) the unit tests, but I've not touched
test_nemo_3D_curvilinear_fieldset.This will solve #2314