Removing time_nextloop from Kernel loop #2333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing the time_nextloop from the KernelLoop, almost all tests work much smoother. A bit of work to be done on some edge cases
By moving the position_update_kernels to after the first kernel loop
As not needed anymore now that SetCoords kernel is only added after first kernel loop
erikvansebille
changed the title
As not necessary anymore now that the last time is written to file
And un-xfailing another particlefile unit test
erikvansebille
added a commit
to reint-fischer/parcels
that referenced
this pull request
Oct 22, 2025
Others are more complex to update, will be done in Parcels-code#2333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the writing of variables in the Kernel loop, and thereby fixes #2331