-
Notifications
You must be signed in to change notification settings - Fork 164
Documentation structure v4 #2349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks Nick! I have fixed the Zulip badge which should work now. I am considering requesting a full review now, as the next things I want to look into are the Reference API and how to outline the Parcels concept explanation files, see main PR message. I could work on those separately from this PR? Or I can wait for your initial review and work on those later and switch to some other tasks for the moment? |
I think that would be best. Its easier if I can review these changes - get them merged, and then get the other changes merged via another PR (otherwise this PR gets too large, or I have to re-review which is difficult) |
|
(re-triggering CI) |
| sphinx-autobuild = "*" | ||
| myst-parser = "*" | ||
| sphinxcontrib-mermaid = "*" | ||
| sphinx-design = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is used for the grid? Happy to add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
pyproject.toml
Outdated
|
|
||
| [tool.ruff.lint.per-file-ignores] | ||
| # Ignore docstring rules everywhere except for the stable files (particleset.py). | ||
| "!src/parcels/_core/{particleset}.py" = [ | ||
| # Missing docstring in public module | ||
| "D100", | ||
| # Missing docstring in public class | ||
| "D101", | ||
| # Missing docstring in public method | ||
| "D102", | ||
| # Missing docstring in public function | ||
| "D103", | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Up to you whether you'd like to manage this in the same file this way, or via a separate file - either works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will move this to a new PR however, where we can implement the Reference API more thoroughly.
| # epub_use_index = True | ||
|
|
||
| # -- Options for MyST parser ---------------------------------------------- | ||
| myst_heading_anchors = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great
| Getting started <getting_started/index> | ||
| Documentation <user_guide/index> | ||
| Community <community/index> | ||
| Contributing <contributing/index> | ||
| API reference <reference> | ||
| Contributing, Release Notes and more <community/index> | ||
| Parcels website <https://parcels-code.org/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the card - I assume the "Getting started" section still needs the quickstart tutorial?
I like the split of "Getting Started" from the rest of the user guide.
I wouldn't mind more sprinkling of TODO comments/note blocks in the documentation (e.g., creating an empty quickstart page with "TODO") to signpost the future development. This makes it easier to review - to have an idea for the structure that you have in mind in a way that is surfaced directly in the website, since at the moment I need to pull from context (e.g., I only deduced that the Quickstart tutorial was planned for the "Getting Started" section via the card on the homepage).
Something like
<!-- nearly empty file docs/getting_started/quickstart.md -->
```{note}
TODO: Write quickstart tutorial. This should focus on ....
```Creating such empty files that need to be filled out is a nice workflow I think - scaffolding things out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thank you!
I have started on some of the tutorials in other PRs, so I will also merge those in, but there is still quite some scaffolding which will be useful
docs/index.md
Outdated
| Getting started <getting_started/index> | ||
| Documentation <user_guide/index> | ||
| Community <community/index> | ||
| Contributing <contributing/index> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should rename Contributing to Development, as that encompasses the different pages inside
Contributing Guidelines
Versioning Policy
Release Notes
Maintainers notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that a lot!
docs/user_guide/index.md
Outdated
| :hidden: | ||
| v3 to v4 migration guide <v4-migration> | ||
| Example scripts <additional_examples> | ||
| Community examples <https://github.com/Parcels-code/parcels_contributions> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the current maintenance status of parcels_contributions, I don't think that we should promote this here in the sidebar. I think its important to distinguish it as a separate project - happy to just reference it in the community section.
e409fc1 to
ac81305
Compare
|
Reminder @reint-fischer : If you want this PR to automatically close any issues on merge, you can put For multiple: Wasn't sure if you wanted this to close #2310 - just thought I'd mention |
63bccc1 to
2d49457
Compare
docs/getting_started/installation.md
Outdated
| conda activate parcels | ||
| ``` | ||
|
|
||
| **Step 4:** Download [a zipped copy](https://docs.parcels-code.org/en/latest/_downloads/307c382eb1813dc691e8a80d6c0098f7/parcels_tutorials.zip) of the Parcels tutorials and examples and unzip it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since #2293 this step 4 is outdated and can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I assume step 5 is too then right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
…utorial/documentation naming split This reverts commit 2d49457.
I have now added some scaffolding which would improve navigation and helps visualise TODO items, but I realised that splitting out notebooks over multiple folders, instead of having them in one “examples” folder, might complicate testing them. Depending on what we decide in #2335 , this might not be such a big problem, but we should figure it out before merging this. |
for more information, see https://pre-commit.ci
…ls-code/Parcels into documentation-structure-v4 pre-commit changes
…ture-v4 resolved changes to documentation folder structure

Implements proposed changes from #2310
Major changes
Notes
In my current view, the strength of our documentation has always been the extended Jupyter Notebooks; tutorials, which I think we should call “How-to guides”, because they are for advanced users and typically answer a “how to?” such as “How to write a Kernel which encodes ARGO behavior?” or “How to set up a FieldSet with a Curvilinear grid?”. I think we should keep this strength, and put it within a “User guide”, which includes beginner tutorials and explanation (.md files) of important Parcels concepts. See Divio for an extended description of the differences between tutorials, explanations, and how-to guides.
TODO:
Fixes #2302