Implement XConstantField interpolation #2361
Open
+24
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since not_all_land could then be [True], throwing an Index error later
|
Was constant field interpolation not working before? I feel that adding support for constant fields via #2054 would probably be a simpler solution than adding a custom interpolator? |
|
The point is that this is a faster interpolation, because it doesn't create a set of indices or requires an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a fast
XConstantFieldinterpolation for Fields that are simply a constant.Also, this PR includes a small fix to the InvDistLandTracer interpolator when only running one particle (since
not_all_landcould then be[True], throwing an Index error later)