switch usage of torch.autograd.functional.vjp to torch.autograd.grad … #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(30% faster) They give the same numeric result, but torch.autograd.grad is a more standard usage, and performance is better for this use case. torch.autograd.functional.vjp is unnecessary because there's no custom input to the pullback, and it was implicitly calling the pullback with the normal unit vector, which is exactly what torch.autograd.grad does anyway
porterchild
force-pushed
the
improve-pytorch-usage
branch
from
6a643d3 to
8b4ae84
Compare
JaapWijnen
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(30% faster)
They give the same numeric result, but torch.autograd.grad is a more standard usage, and performance is better for this use case. torch.autograd.functional.vjp is unnecessary because there's no custom input to the pullback, and it was implicitly calling the pullback with the normal unit vector, which is exactly what torch.autograd.grad does anyway