Skip to content

Conversation

@TheGlitch76
Copy link
Member

@TheGlitch76 TheGlitch76 commented May 25, 2020

I want to preserve forge's magic annotations so that the decompiled bytecode is easier to follow.

@TheGlitch76 TheGlitch76 requested a review from coderbot16 May 25, 2020 02:36
@coderbot16
Copy link
Member

I'm not a huge fan of bringing these annotations back, if possible it would be nice to have them in a separate compilation unit that's not included by default.

Copy link
Member

@coderbot16 coderbot16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are bringing back @SubscribeEvent, it would make sense to include all of the parameters/arguments too (priority, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants