Fix breakdown crash when using Crit Chance Perandus Pact #7617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to add an extra check to every breakdown when we can just set a tonumber on the original value
Contributor
|
I pushed a fix here d541ece |
LocalIdentity
approved these changes
Jun 27, 2024
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7616 .
Description of the problem being solved:
Crash on MH inc. crit chanche / MH crit Chance hover in Calcs Tab when
Perandus Pactwithincreased Global Critical Strike Chancemod used in build.Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: