Skip to content

Add mod parsing support for 3.26 Vile Bastion #8643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2025

Conversation

Ariacell
Copy link
Contributor

@Ariacell Ariacell commented Jun 10, 2025

Description of the problem being solved:

Implements support for the upcoming custom mod on the new version of Vile Bastion in 3.26:
image
ESRegen/sec was already supported, but es per spell block was not (at least that I found)

Hope the flag name is okay, could also be changed from
MaximumEnergyShieldIncreasedByChanceToBlockSpellDamage -> EnergyShieldIncreasedByChanceToBlockSpellDamage
if preferred!

Name changed 👍

Steps taken to verify a working solution:

  • Validated with 0 intelligence character that energy shield is correctly impacted by the custom mod with both item based es and custom config es/spell block mods
  • Checked for no crashed in the calcs breakdown section to confirm the source is mapped correctly
  • Added unit tests for the calculation based on the baseline build with 75% spell block cap

Link to a build that showcases this PR:

https://pobb.in/MbdcjsAu3trY

Before screenshot:

With 50% spell block staff and 100 ES boots (as per linked build)
image
image

After screenshot:

With 50% spell block staff and 100 ES boots (as per linked build)
image
image

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests, this is great! Let's also change the wording to remove "Maximum" and better match the other mods like it.

@Ariacell
Copy link
Contributor Author

Thanks for the quick feedback! Moved/renamed 😃

I'm assuming the inital modcache update is okay by the way? I thought it was surprising that some mods were removed when I refreshed with a fresh checkout of dev, so I've kept that change split out in 4074bb7 just in case I've messed with it somehow.

@Wires77
Copy link
Member

Wires77 commented Jun 11, 2025

Yeah, someone likely didn't regenerate the ModCache and the PR was merged. It's a recent change to our process so I'm not totally surprised. It definitely didn't come from your changes though

@Wires77 Wires77 merged commit 91c1b58 into PathOfBuildingCommunity:dev Jun 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants