Skip to content

Fix Maven Memory Game "CannotBeBlocked" #8781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Blitz54
Copy link
Contributor

@Blitz54 Blitz54 commented Jul 4, 2025

Fixes #
image

Description of the problem being solved:

Maven Memory Game and other boss skills in the Config menu would break Vile Bastion. We were setting the actual Block Chance to 0, so Vile Bastion and any other nodes/skills that use block chance like Mystic Bulwark.

Steps taken to verify a working solution:

  • Skills with CannotBeBlocked do not override output.BlockChance, they do so farther down in the calcs.
  • output.BlockChance is still set to 0 from CannotBlockAttacks or CannotBlockSpells, so things like The Eternal Apple still function.
  • Calcs page still shows block chance on the left, and Unmitigated % shows 100% as expected.

Link to a build that showcases this PR:

https://pobb.in/I6azipBrk7sI

Before Screenshot

image
image

After screenshot:

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant