-
Notifications
You must be signed in to change notification settings - Fork 379
Add progress percentage to book overview #2424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Stuie
wants to merge
6
commits into
PaulWoitaschek:main
Choose a base branch
from
Stuie:add-progress-percentage-to-book-overview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add progress percentage to book overview #2424
Stuie
wants to merge
6
commits into
PaulWoitaschek:main
from
Stuie:add-progress-percentage-to-book-overview
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a book is in progress the progress percentage is displayed iun both list and grid layouts of the book overview. Previews for list and grid items have also been added.
If the book is not in progress the bottom padding would have been removed inadvertently.
And now I look at the open PRs and see #2334 from only a couple of months ago. |
There's probably no need for the progress percentage to be more accurate than a whole number.
…overview' into add-progress-percentage-to-book-overview
Wow! I would love this to be merged, can't wait! Been waiting for mooooonths haha |
Yep, I miss this every time I'm trying to update my progress. There are two PRs for this, other changes have been made, but can't get anyone to look at this, give feedback, or merge it. |
@PaulWoitaschek any chance you can take a look at this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a book is in progress the progress percentage is displayed in both list and grid layouts of the book overview.
Previews for list and grid items have also been added.
Note
I'm posting this PR because progress percentage is something I frequently want when I'm listening to an audiobook. I like to update my progress on book tracking websites (e.g. Bookwyrm or Goodreads), and they only accept page numbers or percentage, not remaining time in hours, minutes, and seconds.
I've tried my best to adhere to the formatting of the files I've edited, but I'll happily make changes if something is amiss.