Skip to content

Conversation

@Toonba
Copy link
Collaborator

@Toonba Toonba commented May 28, 2025

No description provided.

@Pandazaur
Copy link
Collaborator

Inconsistencies & Issues:

  1. Prop naming inconsistencies:
  • Button.md: uses onPress (line 35)
  • Modal.md: uses onClick (line 120-121)
  • Alert.md: pattern uses onClick in examples (line 120)
  • → Should standardize to either onPress or onClick across all components
  1. Typos and language mixing:
  • Button.md line 40: crossMethode should be StyleProp or similar
  • Alert.md line 43: Comment in French suggests prop naming confusion (Status vs variant)
  • Tabs.md line 48: duplicate fullWidth prop (lines 47-48), second should probably be size
  • Select.md line 33: malformed table row with pipes breaking the formatting
  • Input.md line 52: informal comment "Je ne sais pas..." should be removed or formalized
  1. Missing information:
  • Select.md line 24: "Slots / Children autorisés" section is empty (no checkbox marked)
  • Checkbox.md line 28: "Slots / Children autorisés" section is empty
  • Modal.md line 40: table formatting broken (pipes in wrong places)
  1. Accessibility inconsistencies:
  • Button.md line 93: mentions "si button avec text seulement ajouté un aria-label" but this is unclear (should be "icon only")
  • Alert.md line 76: says "Ne jamais forcer le focus" but doesn't specify exceptions clearly
  • Different components use different levels of ARIA detail - some very thorough, others minimal
  1. Props documentation issues:
  • Button.md: type prop description says "default ou danger" but section 4 lists brand and danger (inconsistency)
  • Input.md: variant prop lists variants like mail, phone, etc., but line 52 questions if these should be presets instead
  • Tabs.md: routes prop not clearly documented (what's the object structure?)
  • Checkbox.md line 44: size has no default value specified
  1. Template vs implementation:
  • template.md uses onClick (line 37), but actual specs use onPress - should align
  • Template shows example props that don't match the actual component specs
  1. Section 10 formatting:
  • Most files: "10 Liens utile" should be "10. Liens utiles" (missing dot, missing 's')
  1. Uncompleted sections:
  • Table.md line 89: Section 7 (Présets) is empty
  • Input.md line 95: Section 7 is empty
  • Checkbox.md line 99: Section 7 is empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants