Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor convert_input to Perform tasks via helper function #3338

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

Refactor convert_input to Perform tasks via helper function #3338

wants to merge 29 commits into from

Commits on Jul 18, 2024

  1. Shift functions to check for missing files 

    Return from convert_input via a helper function

Update corresponding test files and add tests to ensure do_conversions isn't affected by current applied changes

Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    614b8f9 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    838af61 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d5e8d24 View commit details
    Browse the repository at this point in the history

  2. Remove unutilized variables from convert_input 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f22b962 View commit details
    Browse the repository at this point in the history

  3. Update logger statements in convert_input 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d884203 View commit details
    Browse the repository at this point in the history

  4. Added seperate function to check machine info 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    68d9516 View commit details
    Browse the repository at this point in the history

  5. Update input args to get machine info 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5208b02 View commit details
    Browse the repository at this point in the history

  6. Correct roxygen documentations 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f570646 View commit details
    Browse the repository at this point in the history

  7. Update tests 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e479c46 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Merge branch 'PecanProject:develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    d9e911b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ed581f7 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    63ac964 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    0f9ac13 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b98617f View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4b771d3 View commit details
    Browse the repository at this point in the history

  2. Refactor extra variables in run.meta.anbalysis 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    63f270f View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Merge branch 'PecanProject:develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    dbb7a6d View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. get existing machine info using helper function 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    74003d9 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    95fb810 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Aug 31, 2024
    Configuration menu
    Copy the full SHA
    2bcb7c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    fcae9bd View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c8e8a02 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Sep 15, 2024
    Configuration menu
    Copy the full SHA
    766174f View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Sep 21, 2024
    Configuration menu
    Copy the full SHA
    d9074df View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'develop' into gsoc/convert-input

    @Sweetdevil144
    Sweetdevil144 authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    94c92f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Applied changes as suggested by @infotroph 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a578be2 View commit details
    Browse the repository at this point in the history

  2. Minor review changes 

    Signed-off-by: Abhinav Pandey <[email protected]>
    @Sweetdevil144
    Sweetdevil144 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    293a68b View commit details
    Browse the repository at this point in the history

  3. Update base/db/R/get.machine.info.R 

    Co-authored-by: Chris Black <[email protected]>
    @Sweetdevil144 @infotroph
    Sweetdevil144 and infotroph authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f7f6926 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Chris Black <[email protected]>
    @Sweetdevil144 @infotroph
    Sweetdevil144 and infotroph authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8f820b0 View commit details
    Browse the repository at this point in the history