Add python lit test coverage #1936
Open
+45
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤯 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1936 +/- ##
==========================================
+ Coverage 96.61% 97.15% +0.54%
==========================================
Files 66 86 +20
Lines 7645 9643 +1998
Branches 898 897 -1
==========================================
+ Hits 7386 9369 +1983
- Misses 195 219 +24
+ Partials 64 55 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mehrdad2m
changed the title
|
Hello. You may have forgotten to update the changelog!
|
I don't think this requires a changelog entry since it includes only build system changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Currently, Catalyst's code coverage reporting only includes Python pytest tests, missing coverage from lit tests. This could result in an incomplete picture of the actual coverage, especially as the Python compiler would rely on lit tests for testing its core compilation functionality.
Description of the Change:
This PR combines lit test coverage with the existing pytest coverage. In particular, it adds a new
lit-coveragetarget for running lit tests with coverage enabled and updatescoverage-frontendto combine pytest and lit coverage data usingcoverage combine.Benefits:
More accurate overall coverage metrics
Possible Drawbacks:
Related GitHub Issues:
[sc-95508]