Skip to content

enforce optimize as an "auxiliary" module #7262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: fix-gradients-dep
Choose a base branch
from

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Apr 11, 2025

Context:

The goal of this PR is to isolate the optimize module as an auxiliary module.

Description of the Change:

  • Removes all top-level imports, import pennylane as qml from this module.
  • Define it to be an auxiliary module in the tach.toml
  • Ignore the fact that optimize (auxiliary), depends on fourier (tertiary) using # tach-ignore ([sc-89244])
  • Cleans up useless pylint disables.

Benefits: Module dependency enforcement

Possible Drawbacks: N/A

[sc-88817]

@andrijapau andrijapau added the WIP 🚧 Work-in-progress label Apr 11, 2025
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (d9a21b6) to head (8a1d240).
Report is 1 commits behind head on fix-gradients-dep.

Additional details and impacted files
@@                Coverage Diff                 @@
##           fix-gradients-dep    #7262   +/-   ##
==================================================
  Coverage              99.64%   99.64%           
==================================================
  Files                    512      512           
  Lines                  50198    50220   +22     
==================================================
+ Hits                   50020    50042   +22     
  Misses                   178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrijapau andrijapau changed the title enforce pennylane.optimize as an "auxiliary" module enforce optimize as an "auxiliary" module Apr 11, 2025
@andrijapau andrijapau added do not merge ⚠️ Do not merge the pull request until this label is removed and removed WIP 🚧 Work-in-progress labels Apr 14, 2025
@andrijapau andrijapau requested a review from albi3ro April 15, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge ⚠️ Do not merge the pull request until this label is removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants