Skip to content

Fixes #2#3

Open
ehhc wants to merge 1 commit intoPentadrago:masterfrom
ehhc:issue#2
Open

Fixes #2#3
ehhc wants to merge 1 commit intoPentadrago:masterfrom
ehhc:issue#2

Conversation

@ehhc
Copy link

@ehhc ehhc commented Dec 20, 2017

I've also added the gradle wrapper files so that a new user don't has to download and install gradle...

Copy link
Owner

@Pentadrago Pentadrago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request.
This commit contains two changes I don't agree with:

  1. The idea plugin is disliked by the Jetbrains People because it uses the old and somehow deprecated configuration format. I'd like to keep IDE stuff from this project and rely on the import functions of the IDEs.
  2. Why did you delete the WarInitializer? This enabled the deployment onto an app server.
    Best regards,
    Steven

@ehhc
Copy link
Author

ehhc commented Feb 20, 2018

Regarding your second question: i've deleted it since it (resp. the used interface) is deprecated in the newer spring versions (cf. https://stackoverflow.com/questions/38843015/spring-boot-springbootservletinitializer-is-deprecated).

But you're correct mentioning that i should have looked for a solution working with the newer spring version instead of deleting it altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants