PS-9697 C++ KMIP client library added#19
Closed
lukin-oleksiy wants to merge 2 commits intoPercona-Lab:masterfrom
Closed
PS-9697 C++ KMIP client library added#19lukin-oleksiy wants to merge 2 commits intoPercona-Lab:masterfrom
lukin-oleksiy wants to merge 2 commits intoPercona-Lab:masterfrom
Conversation
lukin-oleksiy
force-pushed
the
PS-9697-POC-of-kmip-cpp
branch
6 times, most recently
from
ecb590a to
38e07d8
Compare
ktrushin
requested changes
Apr 28, 2025
| kmipclient::AttributesFactory::parse (Attribute *attribute, size_t attribute_count) | ||
| { | ||
| attributes_t res; | ||
| return res; |
Contributor
There was a problem hiding this comment.
Seems to be unimplemented?
| ids_t res; | ||
| for (int i = 0; i < locate_result.ids_size; ++i) | ||
| { | ||
| res.emplace_back (locate_result.ids[i]); |
Contributor
There was a problem hiding this comment.
Seems we have double copying. First, we copy strings pld->unique_ids to locate_result.ids, then - from locate_result.ids to res. Can we eliminated locate_result.ids and copy straight from pld->unique_ids to res?
lukin-oleksiy
force-pushed
the
PS-9697-POC-of-kmip-cpp
branch
from
38e07d8 to
eb16cf2
Compare
lukin-oleksiy
force-pushed
the
PS-9697-POC-of-kmip-cpp
branch
3 times, most recently
from
769d58e to
477236b
Compare
lukin-oleksiy
force-pushed
the
PS-9697-POC-of-kmip-cpp
branch
from
ff5df0a to
604b88c
Compare
lukin-oleksiy
force-pushed
the
PS-9697-POC-of-kmip-cpp
branch
from
a6b36af to
b43b2aa
Compare
The "kmipclient" C++ library implementation is added, that wraps low-level "kmip.h" calls and bypasses mid-level "kmip_bio" level.
https://perconadev.atlassian.net/browse/PS-10068 Addressing PR comments and other fixes, finallizing the interface of the library, adding test suite
lukin-oleksiy
force-pushed
the
PS-9697-POC-of-kmip-cpp
branch
from
b43b2aa to
f5f8fbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "kmipclient" C++ library implementation is added, that wraps low-level "kmip.h" calls and bypasses mid-level "kmip_bio" level.