fix -M option to call import rather than load #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -M option to prove should load modules basically the same way perl does. If given arguments, it should be calling the import method, not trying to call load like it is a plugin. Before 692c19d, import and load would be called both for plugins (-P) and modules (-M). This was causing warnings and possibly in the future errors for the calls to import with extraneous arguments. When attempting to fix this, the call to import was entirely elimintated. That was not correct for the -M option. Instead, -M should call import and -P should call load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -M option to prove should load modules basically the same way perl does. If given arguments, it should be calling the import method, not trying to call load like it is a plugin.
Before 692c19d, import and load would be called both for plugins (-P) and modules (-M). This was causing warnings and possibly in the future errors for the calls to import with extraneous arguments. When attempting to fix this, the call to import was entirely elimintated. That was not correct for the -M option. Instead, -M should call import and -P should call load.