Some deduplications in parser #23838
Open
+388
−378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycoz
reviewed
Oct 12, 2025
embed.fnc
Outdated
Comment on lines
2489
to
2490
| p |void |package_v544 |NN OP *o \ | ||
| |NULLOK OP *v |
There was a problem hiding this comment.
This should probably be called "package2()" if you're going for a non-descriptive new name.
Otherwise package_with_version() or package_and_version() seem more reasonable then either.
There was a problem hiding this comment.
oh, that's what I forgot in PR message ... updated.
Honestly, I prefer API version in another version of function - it clearly says when it was added without need to consult additional tools (which in fact are not aware of semantics)
There was a problem hiding this comment.
@tonycoz Perl_package changed, original functions are now static and new function remains package
added 2 commits
October 18, 2025 06:36
Function combines call of original `package` and `package_version` when new namespace statement is detected. Instead of required three statements usage now consists of single function call.
happy-barney
force-pushed
the
hpb/cleanup
branch
from
0c7fed2 to
fe52a7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal changes - move duplicated code into dedicated functions.