-
Notifications
You must be signed in to change notification settings - Fork 599
Merge the development deltas into a single perldelta #23842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: blead
Are you sure you want to change the base?
Conversation
There is some work needed still:
|
For now this only supports the following sections: * Core Enhancements * Security * Incompatible Changes * Utility Changes
but die the next time we encounter them
in position_of_next_header, the search stops (and fails) whenever a header of higher level is encountered
now we know it exists in both documents, since we're processing the =head1 of the individual deltas
not just the first and last elements...
cbba49e
to
caf6318
Compare
Porting/merge-deltas.pl
Outdated
my $master = tree_for($template_file); | ||
|
||
# loop over all the development deltas | ||
for my $delta ( map tree_for($_), sort glob "pod/perl$tag_devel*delta.pod" ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A simple sort will put perl54310delta.pod
before perl5432delta.pod
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another argument for a new perldelta naming convention for perl 42 44
Since the current perldelta has the latest changes, and we want to keep them in order, we process the deltas in reverse, and therefore inject the text at the beginning of each section, instead of at the end.
Co-authored-by: Eric Herman <[email protected]>
Philippe Bruhat (BooK) <[email protected]>:
This covers almost all cases. The goal is that the release manager will only have the editing work left, and not have to spend time copy/pasting sections from the individual deltas into the final one.
Solves #23365.