Skip to content

Conversation

khwilliamson
Copy link
Contributor

This continues the process started in #23592 to change names with leading underscores to be legal C. See that p.r. or 4bb3572 for extensive discussion.

This commit simply moves the leading underscore to be trailing Some of these may actually be legal, and don't need to be moved, as leading underscores are only illegal in symbols with file scope. But it was easier to just do a global substitute, and does no harm to move them all to be trailing.

  • This set of changes does not require a perldelta entry.

This continues the process started in Perl#23592 to change names with
leading underscores to be legal C.  See that p.r. or
4bb3572 for extensive discussion.

This commit simply moves the leading underscore to be trailing
Some of these may actually be legal, and don't need to be moved, as
leading underscores are only illegal in symbols with file scope.  But it
was easier to just do a global substitute, and does no harm to move them
all to be trailing.
Copy link
Contributor

@tonycoz tonycoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I don't know why we have the underscores at either end of the structure members.

I could see a prefix (like reentr_ as with st_ for stat) to avoid conflicts with wild macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants