perlapi: Combine all forms of Sv[INU] into one entry each #23851
+62
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I looked at the code, and SvUVX looks at the UV slot; so this is a typo
This makes perlapi more compact, and at the same time, easier for readers to compare them and decide which form is best suited for their purposes.
tonycoz
reviewed
Oct 15, 2025
Comment on lines
+782
to
+783
| conversions. Only use when you are sure C<SvIOK> is true. | ||
| C<SvIVXx> is a deprecated synonym for C<SvIVX>. |
There was a problem hiding this comment.
Why are and when were the x suffix names deprecated? (and was that perldeltaed?)
They still the right thing in older perls and harmlessly do the right thing in newer perls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes perlapi more compact, and at the same time, easier for readers to compare these forms and decide which is best suited for their purposes.