Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves Phaiax/Key-n-Stroke#80 #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ckelwin
Copy link

@ckelwin ckelwin commented Jul 31, 2022

@Phaiax Implemented for Shift, CapsLock, Return, Backspace, Tab, PageUp, PageDown, End and Home keys. Added checkbox "Text instead of symbols" in settings to toggle between showing text or symbols. Default is unchecked to retain default behaviour.

image

Unchecked:
image

Checked:
image

@ckelwin
Copy link
Author

ckelwin commented Jul 31, 2022

Found a ⇧ (Shift symbol) in Resources\mouse.svg that is not addressed in this PR.

Copy link
Contributor

@kmpm kmpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this and it basically looks good to me but with some comments.

KeyNStroke/SpecialkeysParser.cs Outdated Show resolved Hide resolved
KeyNStroke/SpecialkeysParser.cs Outdated Show resolved Hide resolved
KeyNStroke/App.xaml.cs Outdated Show resolved Hide resolved
Implemented for Shift, CapsLock, Return, Backspace, Tab, PageUp, PageDown, End and Home keys. Added checkbox "Text instead of symbols" in settings to toggle between showing text or symbols. Default is unchecked to retain default behavior.
ckelwin and others added 2 commits August 19, 2022 17:38
Refactor based on review comments. Passing bool instead of SettingsStore.
@ckelwin
Copy link
Author

ckelwin commented Aug 26, 2022

@kmpm Refactored based on your input.

@Phaiax
Copy link
Owner

Phaiax commented Aug 26, 2022

Thanks a lot @ckelwin and @kmpm, I'll look at this and the other issues and PRs in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants