Open
Conversation
slifty
reviewed
Oct 24, 2025
dbf456a to
7f005d4
Compare
Contributor
Author
|
I tried |
Specify `SENTRY_DSN` to enable (tee of) logging to Sentry/GlitchTip. Issue #1613 Implement audit logging (HTTP request level, 3 of 3)
7f005d4 to
42abfb5
Compare
bickelj
commented
Oct 27, 2025
| }); | ||
| }; | ||
|
|
||
| let logger: pino.Logger; |
Contributor
Author
There was a problem hiding this comment.
Yeah, ESLint wants it to be created here, I'm pretty sure that we only want to instantiate pino exactly once, though, and the various types pino accepts as the second arg make this the seemingly least worst solution.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2081 +/- ##
==========================================
- Coverage 93.06% 93.02% -0.05%
==========================================
Files 304 304
Lines 3534 3542 +8
Branches 505 508 +3
==========================================
+ Hits 3289 3295 +6
- Misses 245 247 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1613 Implement audit logging (HTTP request level, 3 of 3)