Skip to content

Enable GlitchTip via pino-sentry#2081

Open
bickelj wants to merge 1 commit intomainfrom
1613-enable-glitchtip
Open

Enable GlitchTip via pino-sentry#2081
bickelj wants to merge 1 commit intomainfrom
1613-enable-glitchtip

Conversation

@bickelj
Copy link
Contributor

@bickelj bickelj commented Oct 24, 2025

Issue #1613 Implement audit logging (HTTP request level, 3 of 3)

@bickelj bickelj force-pushed the 1613-enable-glitchtip branch from dbf456a to 7f005d4 Compare October 27, 2025 19:37
@bickelj
Copy link
Contributor Author

bickelj commented Oct 27, 2025

I tried pino-sentry-transport locally but entered dep hell, e.g. tomer-yechiel/pino-sentry-transport#272

Specify `SENTRY_DSN` to enable (tee of) logging to Sentry/GlitchTip.

Issue #1613 Implement audit logging (HTTP request level, 3 of 3)
@bickelj bickelj requested a review from slifty October 27, 2025 19:58
@bickelj bickelj marked this pull request as ready for review October 27, 2025 19:58
@bickelj bickelj force-pushed the 1613-enable-glitchtip branch from 7f005d4 to 42abfb5 Compare October 27, 2025 19:59
});
};

let logger: pino.Logger;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, ESLint wants it to be created here, I'm pretty sure that we only want to instantiate pino exactly once, though, and the various types pino accepts as the second arg make this the seemingly least worst solution.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.02%. Comparing base (7cbf883) to head (42abfb5).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/logger.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2081      +/-   ##
==========================================
- Coverage   93.06%   93.02%   -0.05%     
==========================================
  Files         304      304              
  Lines        3534     3542       +8     
  Branches      505      508       +3     
==========================================
+ Hits         3289     3295       +6     
- Misses        245      247       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slifty
Copy link
Member

slifty commented Feb 18, 2026

@kfogel @bickelj I get the sense we ended up hitting pause on this PR -- should we close the PR, or prioritize finishing it (the branch can stick around of course, if we wanna move forward again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants