Retry image decoding on DB path #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
photoroman
reviewed
Jun 12, 2025
| warn!("Failed to decode image from URL: {}. Retrying", url); | ||
| warn!("Error: {:?}", e); | ||
| } | ||
| } |
There was a problem hiding this comment.
Will this not retry in any case now without the return statement?
There was a problem hiding this comment.
l65 it'll return if pattern matched to Ok ?
There was a problem hiding this comment.
Ah yes, of course. I totally missed the return statement there.
There was a problem hiding this comment.
Rust is a mix of returns and non-returns (last line without ; is implicitly return), I think it makes it more confusing and was one of the very few design choice mistakes (that I can see at least).
photoroman
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better take on #127, may not be enough though