address PR feedback for seed support

Author: StrahilPeykov

CHANGELOG.md

@@ -8,7 +8,7 @@ and this project adheres to
 
 ## [Unreleased]
 
-- Add support for linting and scoring dbt seeds (#104)
+- Add support for linting and scoring dbt seeds (#110)
 
 ## [0.11.0] - 2025-04-04
 

docs/seed.md

@@ -69,8 +69,16 @@ def dbt_parse() -> "dbtRunnerResult":
 @dbt_required
 def dbt_ls(select: Iterable[str] | None) -> Iterable[str]:
     """Run dbt ls."""
-    cmd = ["ls", "--resource-types", "model", "source", "snapshot", "seed",
-          "--output", "name"]
+    cmd = [
+        "ls",
+        "--resource-types",
+        "model",
+        "source",
+        "snapshot",
+        "seed",
+        "--output",
+        "name",
+    ]
     if select:
         cmd += ["--select", *select]
 

src/dbt_score/dbt_utils.py

@@ -481,6 +481,7 @@ def __hash__(self) -> int:
         """Compute a unique hash for a snapshot."""
         return hash(self.unique_id)
 
+
 @dataclass
 class Seed(HasColumnsMixin):
     """Represents a dbt seed.
@@ -561,6 +562,7 @@ def __hash__(self) -> int:
 
 Evaluable: TypeAlias = Model | Source | Snapshot | Seed
 
+
 class ManifestLoader:
     """Load the models, sources, snapshots, seeds and tests from the manifest."""
 
@@ -599,8 +601,9 @@ def __init__(self, file_path: Path, select: Iterable[str] | None = None):
         if select:
             self._filter_evaluables(select)
 
-        if (len(self.models) + len(self.sources) + len(self.snapshots)
-            + len(self.seeds)) == 0:
+        if (
+            len(self.models) + len(self.sources) + len(self.snapshots) + len(self.seeds)
+        ) == 0:
             logger.warning("Nothing to evaluate!")
 
     def _load_models(self) -> None:

src/dbt_score/models.py

@@ -14,7 +14,7 @@
     overload,
 )
 
-from dbt_score.models import Evaluable, Model, Snapshot, Source
+from dbt_score.models import Evaluable, Model, Seed, Snapshot, Source
 from dbt_score.more_itertools import first_true
 from dbt_score.rule_filter import RuleFilter
 
@@ -66,8 +66,12 @@ class RuleViolation:
 ModelRuleEvaluationType: TypeAlias = Callable[[Model], RuleViolation | None]
 SourceRuleEvaluationType: TypeAlias = Callable[[Source], RuleViolation | None]
 SnapshotRuleEvaluationType: TypeAlias = Callable[[Snapshot], RuleViolation | None]
+SeedRuleEvaluationType: TypeAlias = Callable[[Seed], RuleViolation | None]
 RuleEvaluationType: TypeAlias = (
-    ModelRuleEvaluationType | SourceRuleEvaluationType | SnapshotRuleEvaluationType
+    ModelRuleEvaluationType
+    | SourceRuleEvaluationType
+    | SnapshotRuleEvaluationType
+    | SeedRuleEvaluationType
 )
 
 
@@ -206,6 +210,11 @@ def rule(__func: SnapshotRuleEvaluationType) -> Type[Rule]:
     ...
 
 
+@overload
+def rule(__func: SeedRuleEvaluationType) -> Type[Rule]:
+    ...
+
+
 @overload
 def rule(
     *,

src/dbt_score/rule.py

@@ -4,16 +4,18 @@
 import typing
 from typing import Any, Callable, Type, TypeAlias, cast, overload
 
-from dbt_score.models import Evaluable, Model, Snapshot, Source
+from dbt_score.models import Evaluable, Model, Seed, Snapshot, Source
 from dbt_score.more_itertools import first_true
 
 ModelFilterEvaluationType: TypeAlias = Callable[[Model], bool]
 SourceFilterEvaluationType: TypeAlias = Callable[[Source], bool]
 SnapshotFilterEvaluationType: TypeAlias = Callable[[Snapshot], bool]
+SeedRuleEvaluationType: TypeAlias = Callable[[Seed], bool]
 FilterEvaluationType: TypeAlias = (
     ModelFilterEvaluationType
     | SourceFilterEvaluationType
     | SnapshotFilterEvaluationType
+    | SeedRuleEvaluationType
 )
 
 
@@ -87,6 +89,11 @@ def rule_filter(__func: SnapshotFilterEvaluationType) -> Type[RuleFilter]:
     ...
 
 
+@overload
+def rule_filter(__func: SeedRuleEvaluationType) -> Type[RuleFilter]:
+    ...
+
+
 @overload
 def rule_filter(
     *,

src/dbt_score/rule_filter.py

@@ -3,6 +3,8 @@
 from dbt_score import Model, RuleViolation, Seed, Severity, Snapshot, rule
 from dbt_score.rules.filters import is_table
 
+MAX_DESCRIPTION_MESSAGE_LENGTH = 60
+
 
 @rule
 def snapshot_has_unique_key(snapshot: Snapshot) -> RuleViolation | None:
@@ -135,6 +137,7 @@ def has_no_unused_is_incremental(model: Model) -> RuleViolation | None:
     ):
         return RuleViolation("Non-incremental model makes use of is_incremental().")
 
+
 @rule
 def seed_has_description(seed: Seed) -> RuleViolation | None:
     """A seed should have a description."""
@@ -149,14 +152,13 @@ def seed_columns_have_description(seed: Seed) -> RuleViolation | None:
         column.name for column in seed.columns if not column.description
     ]
     if invalid_column_names:
-        max_length = 60
         message = f"Columns lack a description: {', '.join(invalid_column_names)}."
-        if len(message) > max_length:
-            message = f"{message[:60]}…"
+        if len(message) > MAX_DESCRIPTION_MESSAGE_LENGTH:
+            message = f"{message[:MAX_DESCRIPTION_MESSAGE_LENGTH]}…"
         return RuleViolation(message=message)
 
 
-@rule
+@rule(severity=Severity.LOW)
 def seed_has_tests(seed: Seed) -> RuleViolation | None:
     """A seed should have at least one test."""
     if not seed.tests and not any(column.tests for column in seed.columns):

src/dbt_score/rules/generic.py

@@ -470,6 +470,7 @@ def evaluate(self, snapshot: Snapshot) -> RuleViolation | None:  # type: ignore[
 
     return SnapshotRuleWithFilter
 
+
 @fixture
 def seed1(raw_manifest) -> Seed:
     """Seed 1."""