Create rule registry and discovery

[matthieucan]

The rule registry has 2 purposes:

• be a container for all known rules
• discover rules in a given namespace

By default, the rule registry looks for rules in 2 places:

• dbt_score.rules, the "core" rules of dbt-score
• dbt_score_rules, a namespace that anyone can use to add custom rules

[jochemvandooren]

Before diving into the code: could you maybe add a some documentation to explain how rule registry works in our package? We will need the documentation anyway, and it will help our reviewing efforts!

[matthieucan]

Before diving into the code: could you maybe add a some documentation to explain how rule registry works in our package? We will need the documentation anyway, and it will help our reviewing efforts!

Can you let me know what you are lacking? Hopefully the docstrings are already helpful.
When it comes to user documentation about the possibilities to add new rules, we'll certainly get there, but given the mechanism is not fully in place yet (i.e. no @rule implementation), I think this should come later.

[jochemvandooren]

Before diving into the code: could you maybe add a some documentation to explain how rule registry works in our package? We will need the documentation anyway, and it will help our reviewing efforts!

Can you let me know what you are lacking? Hopefully the docstrings are already helpful. When it comes to user documentation about the possibilities to add new rules, we'll certainly get there, but given the mechanism is not fully in place yet (i.e. no @rule implementation), I think this should come later.

Yeah I should be able to understand it. Makes sense to write the docs when it is set in stone, I will use the docstrings etc. 👍

[jochemvandooren]

Looks good, works very well locally! 🤩 Just left a few comments with some questions. Also you can make the changes to comply with the new Rule definitions that were merged into master.

[jochemvandooren]

I am trying to understand the expected behavior. Is it correct that this folder should be in the root of the project where users want to run dbt-score? As I understand, this folder can not live for example in a subdirectory. Not sure if this makes sense, we can discuss

[matthieucan]

It doesn't assume any folder structure, but the presence of the namespace dbt_score_rules in the Python path (which can live anywhere, as long as it's known by Python at run time). Does that make sense?

[druzhinin-kirill]

💅

[druzhinin-kirill]

💪
Left a minor comment

[jochemvandooren]

🚀