Remove dbt-core dependency #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochemvandooren
changed the title
jochemvandooren
changed the title
matthieucan
reviewed
Oct 28, 2024
Co-authored-by: Matthieu Caneill <[email protected]>
matthieucan
reviewed
Oct 30, 2024
Co-authored-by: Matthieu Caneill <[email protected]>
Co-authored-by: Matthieu Caneill <[email protected]>
matthieucan
approved these changes
Oct 31, 2024
druzhinin-kirill
approved these changes
Oct 31, 2024
src/dbt_score/dbt_utils.py
Outdated
| def dbt_required(func: Callable[..., Any]) -> Callable[..., Any]: | ||
| """Decorator for methods that require dbt to be installed.""" | ||
|
|
||
| def inner() -> None: |
There was a problem hiding this comment.
We can use https://docs.python.org/3/library/functools.html#functools.wraps
to preserve docstrings, names etc of the original function 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the dependency
dbt-core.In order to keep the number of dependencies as low as possible, to keep python environments small, get rid of the dbt-core dependency and add it to the dev dependencies. This is possible because
dbt-scoreonly needs amanifest.jsonin order to run, althoughdbt-scoreis able to rundbt parseby itself.