Prevent duplicated rule exception when importing rules and filters

[npeshkov]

Fixes #85.

Implementation

• Skip adding imported rules and rule filters to rule registry.
• Split tests/rules/example.py into tests/rules/rules.py and tests/rules/rule_filters.py.
• Test Duplicated exception is not raised by adding an imported skip_schemaX rule filter.

Note

Both rules and rule filters can be imported now, but the existing tests cover only rule filters.

[jochemvandooren]

Only two lines to fix it, that's nice! 🙌

[jochemvandooren]

Suggested change

	# skip adding objects imported from other modules
	# Skip adding objects imported from other modules

🤓

[npeshkov]

Thanks, should be fixed now.

[jochemvandooren]

I don't fully understand why we need a full rules/imported section for this, as we are just fixing a bug. Wouldn't it be simpler to split the existing examples into rules.py and rule_filters.py, add a filter in rule_filters.py that is imported in rules.py? Then it's also a practical use-case that we expect users to have

[npeshkov]

Good point, I have split rules/example.py into rules.py and rule_filters.py, and added a rule filter which is now imported into rules.py. The structure should look better now.

[npeshkov]

The ordering of objects has changed, because files were renamed:

• example used to be before nested,
• now rules and rule_filters come after nested.

[jochemvandooren]

Nice! 🤩

[jochemvandooren]

I will give @matthieucan the final say as he worked on the rule registry

[matthieucan]

Tiny comment, but approving. Thanks!