-
Notifications
You must be signed in to change notification settings - Fork 46
Upgrade OpenRewrite Templating 1.11.2 -> 1.12.0 #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Suggested commit message:
|
54a12df
to
e920ac3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build failed because the generated code now references the deprecated javax.annotation.Generated
annotation, rather than the javax.annotation.processing.Generated
annotation introduced in JDK 9.
I worked around this by adding a legacy dependency, but @timtebeek I wonder whether it'd be possible to (conditionally?) generate code with the newer annotation. (I don't think this will worsen the status quo described in openrewrite/rewrite-third-party#11 (something I've been meaning to have a closer look at, but that's a separate topic), as Java will ignore unknown annotations at runtime.)
Looks good. No mutations were possible for these changes. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
5723ce7
to
78d4a13
Compare
Looks good. No mutations were possible for these changes. |
|
Indeed could be best to remove this requirement; for us in practice it hadn't been an issue as we pin to Java 8 for now, as much as I'd like to allow for newer constructs in our Refaster templates. Haven't explored the options on how to pass configuration into our annotation processor yet, but perhaps you have some ideas or experience there. |
No personal experience, but I think CheckerFramework does this as well, so that should work. (For compiler plugins one can do this and then this, but I suppose annotation processors should be preferred.) Anyway, we merged this PR, so no urgency from our side to change this :) |
This PR contains the following updates:
1.11.2
->1.12.0
1.11.2
->1.12.0
Release Notes
openrewrite/rewrite-templating (OpenRewrite Templating)
v1.12.0
: 1.12.0Compare Source
What's Changed
New Contributors
Full Changelog: openrewrite/rewrite-templating@v1.11.0...v1.12.0