Introduce Class{Literal,Reference}Cast Refaster rules
#1269
Conversation
|
Looks good. No mutations were possible for these changes. |
| return s -> clazz.isInstance(s); | ||
| } | ||
|
|
||
| Function<Number, Integer> testClassLiteralCast() { |
There was a problem hiding this comment.
Curious why the pevious three tests threw exceptions as part of their signature 🤔
There was a problem hiding this comment.
Looks like a copy-paste error; will drop!
| } | ||
| } | ||
|
|
||
| /** Prefer {@link Class#cast(Object)} method references over more verbose alternatives. */ |
There was a problem hiding this comment.
"Verbose" is perhaps a bit strong/unclear. I see that this mirrors the rules above, though. Will propose something.
| return s -> clazz.isInstance(s); | ||
| } | ||
|
|
||
| Function<Number, Integer> testClassLiteralCast() { |
There was a problem hiding this comment.
Looks like a copy-paste error; will drop!
| Class<? extends Integer> clazz = Integer.class; | ||
| return i -> clazz.cast(i); |
There was a problem hiding this comment.
We don't need the separate variable here. (It's used above to test for a non-matching scenario.)
There was a problem hiding this comment.
Ah! Makes sense 👍
Stephan202
changed the title
Class(Reference|Literal)Cast class rulesClass{Literal,Reference}Cast Refaster rules
|
Looks good. No mutations were possible for these changes. |
rickie
force-pushed
the
mohamedsamehsalah/clas-literal-cast
branch
from
543cf41 to
a073a27
Compare
|
Looks good. No mutations were possible for these changes. |
rickie
force-pushed
the
mohamedsamehsalah/clas-literal-cast
branch
from
a073a27 to
553df03
Compare
|
|
Looks good. No mutations were possible for these changes. |
3 participants
Class.class:castalternative more readable, especially when working with Streams.What are your guys thoughts?
Suggested commit message