Skip to content

Conversation

Picnic-DevPla-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
NullAway patch 0.12.5 -> 0.12.6
NullAway compile patch 0.12.5 -> 0.12.6

Release Notes

uber/NullAway (NullAway)

v0.12.6

Compare Source

  • JSpecify: view type as super in generic method inference (#​1177)
  • Infer @​Nullable type arguments for type variables from unmarked code (#​1181)
  • Convert android-jar.py to Python 3 (#​1175)
  • Suggest castToNonNull fix for unboxing error (#​1182)

  • If you want to rebase/retry this PR, check this box

@Picnic-DevPla-Bot
Copy link
Contributor Author

Picnic-DevPla-Bot commented Mar 28, 2025

Suggested commit message: ❗ PR must be merged using rebase-and-fast-forward. ❗

Upgrade NullAway 0.12.5 -> 0.12.6 (#1616)

See:
- https://github.com/uber/NullAway/blob/master/CHANGELOG.md
- https://github.com/uber/NullAway/releases/tag/v0.12.6
- https://github.com/uber/NullAway/compare/v0.12.5...v0.12.6

@Stephan202 Stephan202 added this to the 0.22.0 milestone Mar 29, 2025
@Picnic-DevPla-Bot Picnic-DevPla-Bot force-pushed the renovate/version.nullaway branch 2 times, most recently from 9369cd3 to 248ac4b Compare April 2, 2025 01:19
@rickie
Copy link
Member

rickie commented Apr 2, 2025

Oops, missed that we wanted this one merged first.

So this one, we rebase and merge the two commits :)

Copy link

github-actions bot commented Apr 2, 2025

  • Surviving mutants in this change: 4
  • Killed mutants in this change: 4
class surviving killed
🧟tech.picnic.errorprone.utils.AnnotationAttributeMatcher 4 0
🎉tech.picnic.errorprone.bugpatterns.JUnitValueSource 0 2
🎉tech.picnic.errorprone.experimental.bugpatterns.MethodReferenceUsage 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Picnic-DevPla-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@Stephan202
Copy link
Member

Updated the commit history for rebase-and-fast-forward. Looks like a new SonarCloud bug is triggered, will check later. To be checked whether with this setup #1608 will properly end up in the generated release notes.

Copy link

github-actions bot commented Apr 3, 2025

  • Surviving mutants in this change: 4
  • Killed mutants in this change: 4
class surviving killed
🧟tech.picnic.errorprone.utils.AnnotationAttributeMatcher 4 0
🎉tech.picnic.errorprone.bugpatterns.JUnitValueSource 0 2
🎉tech.picnic.errorprone.experimental.bugpatterns.MethodReferenceUsage 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

  • Surviving mutants in this change: 4
  • Killed mutants in this change: 4
class surviving killed
🧟tech.picnic.errorprone.utils.AnnotationAttributeMatcher 4 0
🎉tech.picnic.errorprone.bugpatterns.JUnitValueSource 0 2
🎉tech.picnic.errorprone.experimental.bugpatterns.MethodReferenceUsage 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member

I rebased and added a commit to work around a false positive with SonarCloud's S2637. It's TBD into which of the two commits I should squash this change.

But first things first: the build now fails due to

Error: Failed to query JRE metadata: GET https://api.sonarcloud.io/analysis/jres?os=linux&arch=x86_64 failed with HTTP 403. Please check the property sonar.token or the environment variable SONAR_TOKEN.

@Stephan202
Copy link
Member

No indication that this token expired. Will see whether this was transient.
image

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the renovate/version.nullaway branch from 2232531 to a1dd062 Compare April 12, 2025 13:18
Copy link

  • Surviving mutants in this change: 4
  • Killed mutants in this change: 4
class surviving killed
🧟tech.picnic.errorprone.utils.AnnotationAttributeMatcher 4 0
🎉tech.picnic.errorprone.bugpatterns.JUnitValueSource 0 2
🎉tech.picnic.errorprone.experimental.bugpatterns.MethodReferenceUsage 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member

The auth error was transient. PR updated; @rickie this one is ready for review.

❗ PR must be merged using rebase-and-fast-forward. ❗

@Stephan202 Stephan202 force-pushed the renovate/version.nullaway branch from a1dd062 to cb8b432 Compare April 14, 2025 07:26
Copy link

Copy link

  • Surviving mutants in this change: 4
  • Killed mutants in this change: 4
class surviving killed
🧟tech.picnic.errorprone.utils.AnnotationAttributeMatcher 4 0
🎉tech.picnic.errorprone.bugpatterns.JUnitValueSource 0 2
🎉tech.picnic.errorprone.experimental.bugpatterns.MethodReferenceUsage 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 merged commit aa988ef into master Apr 14, 2025
17 checks passed
@Stephan202 Stephan202 deleted the renovate/version.nullaway branch April 14, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants