Upgrade OpenRewrite Templating 1.25.1 -> 1.26.1

[Picnic-DevPla-Bot]

This PR contains the following updates:

Package	Type	Update	Change
OpenRewrite Templating		minor	1.25.1 -> 1.26.1
OpenRewrite Templating	compile	minor	1.25.1 -> 1.26.1

---

Release Notes

openrewrite/rewrite-templating (OpenRewrite Templating)

v1.26.1

Compare Source

What's Changed

• Disable resolution warnings by @​fmodesto in https://github.com/openrewrite/rewrite-templating/pull/136
• Add RSPEC tags to generated recipes from suppressed warnings by @​timtebeek in https://github.com/openrewrite/rewrite-templating/pull/137

Full Changelog: openrewrite/rewrite-templating@v1.26.0...v1.26.1

v1.26.0

Compare Source

What's Changed

• add license information to MANIFEST.MF by @​MBoegers in https://github.com/openrewrite/rewrite-templating/pull/135
• Generics by @​fmodesto in https://github.com/openrewrite/rewrite-templating/pull/134

New Contributors

• @​MBoegers made their first contribution in https://github.com/openrewrite/rewrite-templating/pull/135

Full Changelog: openrewrite/rewrite-templating@v1.25.1...v1.26.0

---

• If you want to rebase/retry this PR, check this box

[Picnic-DevPla-Bot]

Suggested commit message:

Upgrade OpenRewrite Templating 1.25.1 -> 1.26.1 (#1644)

See:
- https://github.com/openrewrite/rewrite-templating/releases/tag/v1.26.0
- https://github.com/openrewrite/rewrite-templating/releases/tag/v1.26.1
- https://github.com/openrewrite/rewrite-templating/compare/v1.25.1...v1.26.1

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[timtebeek]

[INFO] -------------------------------------------------------------
Warning:  COMPILATION WARNING : 
[INFO] -------------------------------------------------------------
Warning:  /Users/runner/work/error-prone-support/error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJRules.java:[182,37] unchecked generic array creation for varargs parameter of type E[]
Warning:  /Users/runner/work/error-prone-support/error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJRules.java:[183,47] unchecked generic array creation for varargs parameter of type E[]
Warning:  /Users/runner/work/error-prone-support/error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJRules.java:[184,34] unchecked generic array creation for varargs parameter of type E[]

error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJRules.java

Lines 171 to 186 in bedf588

	@SuppressWarnings("unchecked")
	void before(
	ObjectEnumerableAssert<?, E> enumAssert,
	@Matches(IsEmpty.class) Iterable<? extends E> wellTypedIterable,
	@Matches(IsEmpty.class) Iterable<?> arbitrarilyTypedIterable) {
	Refaster.anyOf(
	enumAssert.containsExactlyElementsOf(wellTypedIterable),
	enumAssert.containsExactlyInAnyOrderElementsOf(wellTypedIterable),
	enumAssert.hasSameElementsAs(wellTypedIterable),
	enumAssert.hasSameSizeAs(arbitrarilyTypedIterable),
	enumAssert.isSubsetOf(wellTypedIterable),
	enumAssert.containsExactly(),
	enumAssert.containsExactlyInAnyOrder(),
	enumAssert.containsOnly(),
	enumAssert.isSubsetOf());
	}

[Stephan202]

Interestingly, this only happens when rewrite-templating is enabled. There seem to be two types of warning:

1. Mostly it's unchecked generic array creation for varargs parameter of type X[].
2. For this line it says:

   [WARNING] /path/to/error-prone-support/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java:[73,85] unchecked cast
     required: T
     found:    java.lang.Object
   

That second warning looks wrong, and seems to hint at generic type erasure (?). I also see that ~each warning is emitted twice. 🤔

I may not have time for a deep-dive in the coming days; @timtebeek do you guys plan to have a look?

[timtebeek]

You're fine to skip this particular version; @fmodesto is still working through his branch of this project, which is likely to result in another release: https://github.com/fmodesto/error-prone-support/tree/openrewrite

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[timtebeek]

• https://github.com/openrewrite/rewrite-templating/releases/tag/v1.26.1

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[Stephan202]

Way more recipes are generated now 🚀. Based on the very crude find . -path "*target/classes/*Recipes*Recipe*class" | wc -l, we went from 896 to 1682 🚀 🚀 🚀 📈

[timtebeek]

That's great! I believe there were still some issues with matching the new generic recipes, but the interface has likely stabilized already. We'll keep an eye on this, thanks!

[mohamedsamehsalah]

🔢

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud