Skip to content

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Apr 19, 2025

Suggested commit message:

Drop IDEA-342187 workaround (#1648)

As of IntelliJ IDEA 2024.3.2.2, the IDE gracefully handles the absence
of explicitly specified annotation processor path dependency versions,
consistent with `maven-compiler-plugin`'s dependency resolution.

@Stephan202 Stephan202 added this to the 0.23.0 milestone Apr 19, 2025
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 added the chore A task not related to code (build, formatting, process, ...) label Apr 19, 2025
pom.xml Outdated
Comment on lines 1625 to 1617
<properties>
<version.reactor-error-prone>0.1.4</version.reactor-error-prone>
</properties>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.github.lhotari</groupId>
<artifactId>reactor-error-prone</artifactId>
<version>${version.reactor-error-prone}</version>
<version>0.1.4</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There'll be some conflicts here with #1649 and #1650; happy to resolve.

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice that we can drop this 🚀 !

As of IntelliJ IDEA 2024.3.2.2, the IDE gracefully handles the absence
of explicitly specified annotation processor path dependency versions,
consistent with `maven-compiler-plugin`'s dependency resolution.
@Stephan202 Stephan202 force-pushed the sschroevers/drop-IDEA-342187-workaround branch from 7c7d387 to ef4ac8c Compare April 19, 2025 20:08
@Stephan202
Copy link
Member Author

Rebased and resolved conflicts. Will merge once built.

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

@Stephan202 Stephan202 merged commit 8a24673 into master Apr 19, 2025
17 checks passed
@Stephan202 Stephan202 deleted the sschroevers/drop-IDEA-342187-workaround branch April 19, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A task not related to code (build, formatting, process, ...)

Development

Successfully merging this pull request may close these issues.

3 participants