Skip to content

Extend AssertThatIsPositive Refaster rule #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extend AssertThatIsPositive Refaster rule #1943

wants to merge 1 commit into from

Conversation

@Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Nov 1, 2025 •
edited
Loading

❗ This PR is on top of #1927. ❗

Suggested commit message:

Extend `AssertThatIsPositive` Refaster rule (#1943)

By simplifying expressions referencing `Duration#isPositive()`,
introduced with Java 18.

@Stephan202 Stephan202 added this to the 0.27.0 milestone Nov 1, 2025
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 mentioned this pull request Nov 1, 2025
Merged
mohamedsamehsalah
mohamedsamehsalah approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🏫

@rickie rickie force-pushed the sschroevers/target-jdk-21 branch 2 times, most recently from 96f070e to 67d7d5f Compare November 6, 2025 15:45
Base automatically changed from sschroevers/target-jdk-21 to master November 6, 2025 16:09
@Stephan202
Extend AssertThatIsPositive Refaster rule
b8de3fd 
By simplifying expressions referencing `Duration#isPositive()`,
introduced with Java 18.
@Stephan202 Stephan202 force-pushed the sschroevers/update-AssertThatIsPositive branch from 89707b5 to b8de3fd Compare November 11, 2025 21:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie Awaiting requested review from rickie

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

improvement

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Stephan202 @mohamedsamehsalah