Skip to content

Conversation

@Picnic-DevPla-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
Project Reactor (source) import major 2024.0.11 -> 2025.0.0

Release Notes

reactor/reactor (Project Reactor)

v2025.0.0

Compare Source

2025.0.0 release train is made of:

v2024.0.12

Compare Source

2024.0.12 release train is made of:

These artifacts didn't have any changes:


  • If you want to rebase/retry this PR, check this box

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit to manage the version of org.reactivestreams:reactive-streams, as the BOM no longer does this. I filed reactor/reactor#768 to ask for a release notes entry or revert.

The build won't pass yet, as I'll need to address some NullAway warnings due to the new JSpecify support.

Suggested commit message:

Upgrade Project Reactor 2024.0.11 -> 2025.0.0 (#1969)

See:
- https://github.com/reactor/reactor/releases/tag/2024.0.12
- https://github.com/reactor/reactor/releases/tag/2025.0.0
- https://github.com/reactor/reactor/compare/2024.0.11...2025.0.0

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[javac] reported by reviewdog 🐶
[NullAway] returning @nullable expression from method with @nonnull return type

return flux.map(v -> transformation(v)).mapNotNull(o -> o.orElse(null));

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msridhar perhaps I'm overlooking something trivial, but I'm not sure how to resolve this warning and the two similar ones shown below. Now that Project Reactor adopted JSpecify, the signature of Flux#mapNotNull is:

public final <V> Flux<V> mapNotNull(Function <? super T, ? extends @Nullable V> mapper)

The use of .orElse(null) here seems compatible with that. Note that the warning is reported on the whole o -> o.orElse(null) lambda expression.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might get resolved by uber/NullAway#1337 (FYI @dhruv-agr). We will try testing on our end and let you know. If you need to merge this in the meantime, I think you'll have to suppress.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for the quick response; clear! 💪

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[javac] reported by reviewdog 🐶
[NullAway] returning @nullable expression from method with @nonnull return type

return flux.mapNotNull(x -> transformation(x).orElse(null));

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[javac] reported by reviewdog 🐶
[NullAway] returning @nullable expression from method with @nonnull return type

@Stephan202 Stephan202 force-pushed the renovate/project-reactor-2025.x branch from cf25141 to aa9a7af Compare November 9, 2025 11:50
@Stephan202 Stephan202 changed the base branch from master to sschroevers/improve-reviewdog-reporting November 9, 2025 11:51
@Stephan202
Copy link
Member

Stephan202 commented Nov 9, 2025

❗ I rebased this PR on top of #1970. That one must be merged first. ❗

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 added this to the 0.27.0 milestone Nov 9, 2025
@Picnic-DevPla-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@rickie rickie force-pushed the sschroevers/improve-reviewdog-reporting branch from 4a1a160 to 78355bb Compare November 10, 2025 08:18
Base automatically changed from sschroevers/improve-reviewdog-reporting to master November 10, 2025 08:36
@Stephan202 Stephan202 force-pushed the renovate/project-reactor-2025.x branch from aa9a7af to 841bc6f Compare November 10, 2025 08:37
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the renovate/project-reactor-2025.x branch from 841bc6f to 58644c2 Compare November 10, 2025 21:23
@sonarqubecloud
Copy link

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants