-
Notifications
You must be signed in to change notification settings - Fork 48
Upgrade Project Reactor 2024.0.11 -> 2025.0.0 #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Looks good. No mutations were possible for these changes. |
Stephan202
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit to manage the version of org.reactivestreams:reactive-streams, as the BOM no longer does this. I filed reactor/reactor#768 to ask for a release notes entry or revert.
The build won't pass yet, as I'll need to address some NullAway warnings due to the new JSpecify support.
Suggested commit message:
Upgrade Project Reactor 2024.0.11 -> 2025.0.0 (#1969)
See:
- https://github.com/reactor/reactor/releases/tag/2024.0.12
- https://github.com/reactor/reactor/releases/tag/2025.0.0
- https://github.com/reactor/reactor/compare/2024.0.11...2025.0.0
|
Looks good. No mutations were possible for these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msridhar perhaps I'm overlooking something trivial, but I'm not sure how to resolve this warning and the two similar ones shown below. Now that Project Reactor adopted JSpecify, the signature of Flux#mapNotNull is:
public final <V> Flux<V> mapNotNull(Function <? super T, ? extends @Nullable V> mapper)The use of .orElse(null) here seems compatible with that. Note that the warning is reported on the whole o -> o.orElse(null) lambda expression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might get resolved by uber/NullAway#1337 (FYI @dhruv-agr). We will try testing on our end and let you know. If you need to merge this in the meantime, I think you'll have to suppress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tnx for the quick response; clear! 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cf25141 to
aa9a7af
Compare
|
|
|
Looks good. No mutations were possible for these changes. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
4a1a160 to
78355bb
Compare
aa9a7af to
841bc6f
Compare
|
Looks good. No mutations were possible for these changes. |
841bc6f to
58644c2
Compare
|
|
Looks good. No mutations were possible for these changes. |
1 similar comment
|
Looks good. No mutations were possible for these changes. |



This PR contains the following updates:
2024.0.11->2025.0.0Release Notes
reactor/reactor (Project Reactor)
v2025.0.0Compare Source
2025.0.0release train is made of:3.8.03.6.01.2.01.3.01.3.0v2024.0.12Compare Source
2024.0.12release train is made of:3.7.131.1.61.2.121.2.51.3.25These artifacts didn't have any changes:
3.5.4